fix(conform-zod): when should default to true

packages/conform-zod/index.ts

@@ -294,7 +294,7 @@ export function refine(
 		path?: z.IssueData['path'];
 	},
 ): void | Promise<void> {
-	if (!options.when) {
+	if (typeof options.when !== 'undefined' && !options.when) {
 		ctx.addIssue({
 			code: z.ZodIssueCode.custom,
 			message: VALIDATION_SKIPPED,

tests/conform-zod.spec.ts

@@ -3,6 +3,7 @@ import {
 	getFieldsetConstraint,
 	parse,
 	ifNonEmptyString,
+	refine,
 } from '@conform-to/zod';
 import { z } from 'zod';
 import { installGlobals } from '@remix-run/node';
@@ -267,4 +268,79 @@ test.describe('conform-zod', () => {
 			},
 		});
 	});
+
+	test('parse with refine', () => {
+		const createSchema = (
+			validate?: (email) => Promise<boolean> | boolean,
+			when?: boolean,
+		) =>
+			z.object({
+				email: z
+					.string()
+					.email()
+					.superRefine((email, ctx) =>
+						refine(ctx, {
+							validate: () => validate?.(email),
+							when,
+							message: 'Email is invalid',
+						}),
+					),
+			});
+		const formData = createFormData([['email', '[email protected]']]);
+		const submission = {
+			intent: 'submit',
+			payload: {
+				email: '[email protected]',
+			},
+		};
+
+		expect(parse(formData, { schema: createSchema() })).toEqual({
+			...submission,
+			error: {
+				email: '__undefined__',
+			},
+		});
+		expect(parse(formData, { schema: createSchema(() => false) })).toEqual({
+			...submission,
+			error: {
+				email: 'Email is invalid',
+			},
+		});
+		expect(parse(formData, { schema: createSchema(() => true) })).toEqual({
+			...submission,
+			error: {},
+			value: submission.payload,
+		});
+		expect(
+			parse(formData, { schema: createSchema(() => true, false) }),
+		).toEqual({
+			...submission,
+			error: {
+				email: '__skipped__',
+			},
+		});
+		expect(
+			parse(formData, { schema: createSchema(() => false, false) }),
+		).toEqual({
+			...submission,
+			error: {
+				email: '__skipped__',
+			},
+		});
+		expect(
+			parse(formData, { schema: createSchema(() => false, true) }),
+		).toEqual({
+			...submission,
+			error: {
+				email: 'Email is invalid',
+			},
+		});
+		expect(parse(formData, { schema: createSchema(() => true, true) })).toEqual(
+			{
+				...submission,
+				error: {},
+				value: submission.payload,
+			},
+		);
+	});
 });