[entrypoint] validate connection str and escape special chars #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflambert
reviewed
Mar 2, 2023
entrypoint.sh
Outdated
| @@ -11,6 +11,16 @@ PG_CONFIG_DIR=/etc/pgbouncer | |||
| if [ -n "$DATABASE_URL" ]; then | |||
| # Thanks to https://stackoverflow.com/a/17287984/146289 | |||
|
|
|||
| # Check that begins with valid postgres:// prefix and has at max one '@' char | |||
| charcount=$(echo $DATABASE_URL | grep -o "@" | wc -l) | |||
| if [[ ! "$DATABASE_URL" =~ ^postgres:// ]]; then | |||
There was a problem hiding this comment.
postgresql is also valid and some python library stopped supporting postgres
There was a problem hiding this comment.
I realize it's also possible to have formats like:
DATABASE_URL=postgresql+asyncpg://username:password@host:port/dtabase_name
so i think it's easiest to remove the check for connection string formatting for now
|
This is now updated to remove the connection string format validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that connection string begins with a valid
postgres://and contains at max one@character.Escapes
*and.special chars when parsing the hostport from the connection string.