-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use tini as entrypoint #98
base: master
Are you sure you want to change the base?
Conversation
Do you have more info about Dependabot |
Microsoft offers free usage for Open-Source projects, it automatically creates PRs when it sees updates: My example configuration searches for updates of Docker image tags in Dockerfile, docker-compose.yml and Kubernetes manifests. |
I've used tini in other projects where, as you say, I needed to handle some signals gracefully or other esoteric things (subreaping, capture some non-standard output). Which problems does this solve for pgbouncer? |
ARG VERSION=1.22.1 | ||
|
||
# Inspiration from https://github.com/gmr/alpine-pgbouncer/blob/master/Dockerfile | ||
# hadolint ignore=DL3003,DL3018 | ||
RUN \ | ||
# security | ||
apk add -U --no-cache --upgrade busybox && \ | ||
# https://github.com/krallin/tini#existing-entrypoint | ||
apk add -U --no-cache --upgrade tini --repository=https://dl-cdn.alpinelinux.org/alpine/v3.20/community && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the --repository
switch necessary if we're already using alpine 3.20?
feels like tini
could be added to line 8 instead
Updates
Improvements
Transfer size (compressed image) should be