This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
#109 permissive marcreader #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2019 21:39
as MARCReaderStringTest was MARCReaderFileTest child some test dedicated to MARCReaderFileTest was running in MARCReaderStringTest test class with no additionnal values as they were not using self.reader
This allow to read a large amont of data that may contains wrong structural records which will be ignore to give a chance to read as much of possible of recods in a file even one is incorect
|
FWIW the 2.6 failure is kind of obnoxious and I'm +1 on dropping support at this point. (I'd also be for dropping py2.7 support but that may be a harder sell...) |
|
@Wooble thanks for your quick feed back I'll remove test against 2.6 them ! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address #109 which allow to read files that may contains record with some structural errors.