Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing utf8 encoding #4

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

despairblue
Copy link
Contributor

Also some older, smaller things for which I obviously forgot to open a PR a couple of month ago. My bad.

Danny Arnold and others added 12 commits June 5, 2014 12:22
Wikipedia hashes UTF-8 strings. JS strings are ASCII strings, so hashing
file names containing non ASCII characters results in wrong hashes. That
results in wrong image URLs. Encoding the file names in UTF-8 before
hashing fixes this.
Conflicts:
	src/wikigeo.coffee
@edsu edsu reopened this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants