Skip to content

Commit

Permalink
fix: address suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Henrrypg committed Jun 12, 2024
1 parent fae6eb7 commit 05c6487
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 28 deletions.
19 changes: 11 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@ jobs:
fetch-depth: 0

- name: Python Semantic Release
uses: python-semantic-release/python-semantic-release@master
uses: actions/setup-python@v2
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
git_committer_name: 'Automatic Release Bot'
git_committer_email: '[email protected]'
commit: true
tag: true
changelog: true
push: true
python-version: 3.8

- name: Install dependencies
run: |
pip install -e .[dev]
- name: Run Semantic Release
run: make release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
11 changes: 7 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
.DEFAULT_GOAL := help

install-semantic-release: ## install semantic-release
@echo "Installing semantic-release."
pip install python-semantic-release

release: ## release a new version
@echo "Releasing a new version."
@echo "This is a remote release, it will push to the remote repository."
semantic-release -vv version --changelog --push --tag --commit

local-release:
@echo "Releasing a new version."
@echo "This is a local release, it will not push to the remote repository."
@echo "You can push the changes and release manually."
semantic-release -vv version --changelog --commit --no-push

selfcheck: ## check that the Makefile is well-formed
@echo "The Makefile is well-formed."

Expand Down
25 changes: 9 additions & 16 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "drydock"
version = "16.5.0"
dynamic = ["version"]
description = "A Tutor plugin to manage our opinionated Open edX operations"
readme = "README.md"
requires-python = ">=3.8"
Expand All @@ -25,7 +25,12 @@ classifiers = [
"Programming Language :: Python :: 3.12",
]
dependencies = [
"tutor>=17.0.2,<18.0.0"
"tutor>=16.0.0,<17.0.0"
]

[project.optional-dependencies]
dev = [
"python-semantic-release",
]

[project.urls]
Expand All @@ -40,20 +45,14 @@ exclude = ["tests*"]
[project.entry-points."tutor.plugin.v1"]
drydock = "drydock.plugin"

[tool.isort]
include_trailing_comma = true
indent = " "
line_length = 120
multi_line_output = 3
[tool.setuptools.dynamic]
version = {attr = "drydock.__about__.__version__"}

[tool.wheel]
universal = true

[tool.semantic_release]
commit_message = "chore(release): preparing {version}"
version_toml = [
"pyproject.toml:project.version",
]
version_variables = [
"drydock/__about__.py:__version__",
]
Expand All @@ -63,9 +62,3 @@ match = "palm"

[tool.semantic_release.changelog.environment]
keep_trailing_newline = true

[tool.semantic_release.remote]
name = "origin"
type = "github"
ignore_token_for_push = false
insecure = false

0 comments on commit 05c6487

Please sign in to comment.