Skip to content

Commit

Permalink
fix: drop celery support (#129)
Browse files Browse the repository at this point in the history
  • Loading branch information
Cristhian Garcia authored Aug 13, 2024
1 parent 6235a74 commit 86f2639
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 88 deletions.
2 changes: 0 additions & 2 deletions .github/environments/disabled/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ PLUGINS:
- mfe
- drydock
DRYDOCK_BYPASS_CADDY: false
DRYDOCK_FLOWER: false
DRYDOCK_INGRESS: false
DRYDOCK_DEBUG: false
DRYDOCK_ENABLE_CELERY_TUNING: false
DRYDOCK_ENABLE_MULTITENANCY: false
DRYDOCK_ENABLE_SCORM: false
DRYDOCK_POD_LIFECYCLE: false
Expand Down
2 changes: 0 additions & 2 deletions .github/environments/enabled/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ PLUGINS:
- drydock
- s3
DRYDOCK_BYPASS_CADDY: true
DRYDOCK_FLOWER: true
DRYDOCK_INGRESS: true
DRYDOCK_DEBUG: true
DRYDOCK_ENABLE_CELERY_TUNING: true
DRYDOCK_ENABLE_MULTITENANCY: true
DRYDOCK_ENABLE_SCORM: true
DRYDOCK_POD_LIFECYCLE: true
Expand Down
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ Drydock is an opinionated tool offering a set of Tutor plugins aiming to provide
- A set of Kustomization overrides adding [ArgoCD Sync Waves](https://argo-cd.readthedocs.io/en/stable/user-guide/sync-waves/) annotations to needed additional resources such as debug, workers or hpa.
- Backup cronjobs that allow backup of the MySQL and MongoDB databases.
- Integration of New Relic monitoring
- Add flower deployment for Celery
- Add a custom nginx and cert-manager configuration
- Add a set of debug resources to help diagnose issues

Extra plugins added:

- A patch that allows for the tuning of celery workers via `DRYDOCK_ENABLE_CELERY_TUNING`
- Allows caddy to catch requests for multiple domains through `DRYDOCK_ENABLE_MULTITENANCY`
- Add scorm matcher to caddy through `DRYDOCK_ENABLE_SCORM`
- Patch for cms and lms worker pods to allow pod probes and lifecycle to work properly. Enabled via `DRYDOCK_POD_LIFECYCLE`
Expand Down Expand Up @@ -59,14 +57,12 @@ The following configuration options are available:
- `DRYDOCK_INIT_JOBS`: Whether run the initialization jobs or not. Defaults to `false`.
- `DRYDOCK_CMS_SSO_USER`: The username of the CMS SSO user. Defaults to `cms`.
- `DRYDOCK_AUTO_TLS`: Whether to use cert-manager to automatically generate TLS certificates. Defaults to `false`.
- `DRYDOCK_FLOWER`: Whether to deploy a flower deployment for celery. Defaults to `false`.
- `DRYDOCK_INGRESS`: Whether to deploy an ingress for the LMS and CMS. Defaults to `false`.
- `DRYDOCK_INGRESS_EXTRA_HOSTS`: A list of extra hosts to add to the ingress. Defaults to `[]`.
- `DRYDOCK_INGRESS_LMS_EXTRA_HOSTS`: A list of extra hosts to add to the LMS ingress. Defaults to `[]`.
- `DRYDOCK_CUSTOM_CERTS`: A dictionary of custom certificates to use with cert-manager. Defaults to `{}`.
- `DRYDOCK_NEWRELIC_LICENSE_KEY`: The New Relic license key. Defaults to `""`.
- `DRYDOCK_DEBUG`: Whether to deploy debug resources. Defaults to `false`.
- `DRYDOCK_ENABLE_CELERY_TUNING`: Whether to enable celery tuning. Defaults to `true`.
- `DRYDOCK_ENABLE_MULTITENANCY`: Whether to enable multitennacy. Defaults to `true`.
- `DRYDOCK_ENABLE_SCORM`: Whether to enable scorm. Defaults to `true`.
- `DRYDOCK_POD_LIFECYCLE`: Whether to enable pod lifecycle. Defaults to `true`.
Expand Down
3 changes: 0 additions & 3 deletions drydock/patches/cms-env
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
{% if DRYDOCK_ENABLE_CELERY_TUNING -%}
CELERY_ACKS_LATE: true
{% endif %}
4 changes: 0 additions & 4 deletions drydock/patches/kustomization
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ patches:
kind: Job
labelSelector: app.kubernetes.io/component=job
path: plugins/drydock/k8s/patches/tutor-jobs.yml
{% if DRYDOCK_ENABLE_CELERY_TUNING %}
- path: plugins/drydock/k8s/celery/cms-worker.yml
- path: plugins/drydock/k8s/celery/lms-worker.yml
{% endif -%}
- target:
kind: HorizontalPodAutoscaler
path: plugins/drydock/k8s/patches/hpa-sync-wave.yml
Expand Down
3 changes: 0 additions & 3 deletions drydock/patches/kustomization-resources
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
{%- if DRYDOCK_INIT_JOBS %}
- plugins/drydock/k8s/jobs.yml
{%- endif %}
{% if DRYDOCK_FLOWER -%}
- plugins/drydock/k8s/flower.yml
{%- endif %}
{% if DRYDOCK_INGRESS -%}
- plugins/drydock/k8s/ingress/issuer.yml
- plugins/drydock/k8s/ingress/lms.yml
Expand Down
3 changes: 0 additions & 3 deletions drydock/patches/lms-env
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
{% if DRYDOCK_ENABLE_CELERY_TUNING -%}
CELERY_ACKS_LATE: true
{% endif %}
2 changes: 0 additions & 2 deletions drydock/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ def get_sync_waves_for_resource(resource_name: str) -> SYNC_WAVES_ORDER_ATTRS_TY
"CMS_SSO_USER": "cms",
"AUTO_TLS": True,
"MIGRATE_FROM": 0,
"FLOWER": False,
"INGRESS": False,
"INGRESS_EXTRA_HOSTS": [],
"INGRESS_LMS_EXTRA_HOSTS": [],
Expand All @@ -141,7 +140,6 @@ def get_sync_waves_for_resource(resource_name: str) -> SYNC_WAVES_ORDER_ATTRS_TY
"CUSTOM_CERTS": {},
"DEBUG": False,
"LETSENCRYPT_EMAIL": "{{ CONTACT_EMAIL }}",
"ENABLE_CELERY_TUNING": True,
"ENABLE_MULTITENANCY": True,
"ENABLE_SCORM": True,
"POD_LIFECYCLE": True,
Expand Down
20 changes: 0 additions & 20 deletions drydock/templates/drydock/k8s/celery/cms-worker.yml

This file was deleted.

20 changes: 0 additions & 20 deletions drydock/templates/drydock/k8s/celery/lms-worker.yml

This file was deleted.

25 changes: 0 additions & 25 deletions drydock/templates/drydock/k8s/flower.yml

This file was deleted.

0 comments on commit 86f2639

Please sign in to comment.