feat send team emails #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnvente
force-pushed
the
jv/feat-send-team-emails-pluggable
branch
from
0a0b15d
to
bcd7e63
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jv/feat-send-indivudial-email-pluggable #8 +/- ##
========================================================================
Coverage 83.31% 83.31%
========================================================================
Files 53 53
Lines 773 773
Branches 147 147
========================================================================
Hits 644 644
Misses 129 129 ☔ View full report in Codecov by Sentry. |
johnvente
force-pushed
the
jv/feat-send-team-emails-pluggable
branch
from
bcd7e63
to
01f8c9f
Compare
01001110J
reviewed
Jan 4, 2024
| import ListTeams from './ListTeams'; | ||
|
|
||
| describe('ListTeams component', () => { | ||
| // eslint-disable-next-line no-unused-vars, react/prop-types |
There was a problem hiding this comment.
'no-unused-vars' isn't necessary, I will remove it. Thanks!
01001110J
reviewed
Jan 5, 2024
|
|
||
| const formStatusToast = ['error', 'complete', 'completeSchedule']; | ||
| const formStatusToast = ['error', 'complete', 'completeSchedule', 'loadingTeams']; |
There was a problem hiding this comment.
I've seen this status in many different places, I would suggest to move into a variables, in order to avoid typos in the future.
Ej:
Suggested change
| const formStatusToast = ['error', 'complete', 'completeSchedule', 'loadingTeams']; | |
| const ERROR = 'error' | |
| const COMPLETE = 'complete' | |
| const COMPLETE_SCHEDULE = 'completeSchedule' | |
| const LOADING_TEAMS = 'loadingTeams' | |
| const formStatusToast = [ERROR, COMPLETE, COMPLETE_SCHEDULE, LOADING_TEAMS]; |
| }), [intl]); | ||
|
|
||
| const statefulButtonDisableStates = useMemo(() => [ | ||
| 'pending', | ||
| 'complete', | ||
| 'completeSchedule', | ||
| ], []); | ||
| isLoadingTeams ? 'loadingTeams' : '', |
There was a problem hiding this comment.
Same about this states:
Suggested change
| isLoadingTeams ? 'loadingTeams' : '', | |
| COMPLETE_SCHEDULE, | |
| isLoadingTeams ? LOADING_TEAMS : '', |
| data-testid="send-email-btn" | ||
| variant="primary" | ||
| onClick={handleClickStatefulButton} | ||
| state={isLoadingTeams ? 'loadingTeams' : formStatus} |
There was a problem hiding this comment.
Same here:
Suggested change
| state={isLoadingTeams ? 'loadingTeams' : formStatus} | |
| state={isLoadingTeams ? LOADING_TEAMS : formStatus} |
BryanttV
approved these changes
Jan 5, 2024
|
Works as expected! 🚀 |
AuraAlba
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows you to send emails to specific teams in a course. The teams will be displayed as checkboxes, and the user will be able to select the teams as they wish.
Demo
demo.mp4
When teams are being fetched
Plugin loaded
How to test it
Setting up
You will need to install these following plugins:
If you are using devstack
Go to http://localhost:1984/courses/course-v1:edX+DemoX+Demo_Course/bulk_email Or
http://localhost:1984/courses/{{id_course}}/bulk_email
Select any team or some teams in the field called "teams"
Fill out the fields Subject and Body