Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply getPath to PUBLIC_PATH to allow use with CDN #11

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: apply getPath to PUBLIC_PATH to allow use with CDN #11

merged 1 commit into from
Aug 20, 2024

Conversation

dcoa
Copy link
Collaborator

@dcoa dcoa commented Aug 20, 2024 •
edited
Loading

Description

When ORA is configured to be used with CDN the locationId is unresolved because PUBLIC_PATH is not fully matched.

image

The API returns 404 because the location has /ora-grading/.

How to replicate

  1. Set the public path to a URL, e.g. ENV PUBLIC_PATH='http://apps.local.edly.io/ora-grading/'
  2. Load the ORA-Grading MFE
  3. Check the request.

@dcoa dcoa requested a review from a team August 20, 2024 05:25
bra-i-am
bra-i-am approved these changes Aug 20, 2024
View reviewed changes
Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @dcoa. It is working as expected!

image

mariajgrimaldi
mariajgrimaldi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working perfectly! Thank you

@dcoa dcoa merged commit 3e9b1b1 into ednx-release/redwood.master Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@bra-i-am bra-i-am bra-i-am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcoa @mariajgrimaldi @bra-i-am