Site level configuration for Akismet and Mailgun #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staticman will read akismet configuration from siteConfig in first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aimed to cover issue #369 and #370. Following properties was added into siteConfig in this PR, which allowing site owner to override them on per site basis.
akismet.site: Site URL defined on Akismet. Should be anEncryptedString.akismet.apiKey: ApiKey provided by Akismet. Should be anEncryptedString.notifications.fromAddress: Custom sender address. Should be anEncryptedString. This property should match to the domain configured in same section. This property was documented as overridable but not implemented.This PR also update the notification template to make overridden sender address take effect.