Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid collision of key binding on win32 and linux #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid collision of key binding on win32 and linux #43

wants to merge 1 commit into from

Conversation

colin-kiegel
Copy link

atom-core defines this keybindings for 'f3' but none for 'f1'

'.platform-win32 atom-text-editor, .platform-linux atom-text-editor':
'f3': 'find-and-replace:find-next'

This pull requests makes the racer-keybinding work on win32 and linux by default.

atom-core defines this keybindings for 'f3' but none for 'f1'

'.platform-win32 atom-text-editor, .platform-linux atom-text-editor':
  'f3': 'find-and-replace:find-next'

This pull requests makes the racer-keybinding work on win32 and linux by default.
@alkama
Copy link
Contributor

alkama commented Jul 21, 2015

Those collisions are unavoidable and noone can tell that F1 wont collide with something else that ppl use.
Wouldn't it be better to document in the Readme how each user can bind the feature to his favorite key?

@colin-kiegel
Copy link
Author

@alkama: Yes and No.

  • Yes: General collisions of key-bindings of other packages are unavoidable. And noone can tell that F1 wont collide with something else that ppl use.
  • and No: This is a collision with atom-core (not on osx, but on linux and on windows). Those can and should be avoided imo.

@alkama
Copy link
Contributor

alkama commented Jul 21, 2015

Makes sense

@colin-kiegel
Copy link
Author

Of course one should check if the alternative F1 collides with OS key bindings (like help) on windows and osx. It works fine on ubuntu gnome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants