added functionality to make atom-racer find racer_bin on the path #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cleaned up some code - added a for-loop for loop through the process.env.PATH and find the racer binary
|
I added a function |
|
Nice work! which OS'es has this been tested on? |
|
I only have OSX. Now that I think of it, there might be issues on Windows because it separates the path with "/" and not "". But that just mean it shouldn't work on windows. Not break it entirely. |
|
I could use regex instead... |
|
Would love for someone to test this out on Windows and get this rebased and merged in. |
|
oh! I had forgotten about this pull request, I'll try to get this working |
|
This functionality has been added to https://github.com/Xaeroxe/atom-racer and published as racer-plus |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
racer binary