This repository has been archived by the owner on Sep 1, 2020. It is now read-only.
exclude missing profiles from stats #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this is already fixed in vpn-admin-portal/views/vpnStats.php Line 40 in 506a768 |
|
also when stats are available, but when no (current) profiles match the available stats, a different message should be shown.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing the Stats page just after renaming a profile, it will fail with
Key "internet" for array with keys "uninett" does not exist in "vpnStats.twig" at line 41.. This is because the list of statistics doesn't match the list of actual profiles.This PR excludes profiles from
$stats['profiles']that are missing from$profileList.