Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable NR for edxapp and gate it on new edxapp-specific variable #74

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

timmc-edx
Copy link
Member

Introduces EDXAPP_NEWRELIC_ENABLE and sets it to false so edxapp is no longer drawing from the common COMMON_ENABLE_NEWRELIC_APP variable.

This is now possible thanks to fixes in ddtrace 2.14.2.

See edx/edx-arch-experiments#692


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

Introduces `EDXAPP_NEWRELIC_ENABLE` and sets it to false so edxapp is no
longer drawing from the common `COMMON_ENABLE_NEWRELIC_APP` variable.

This is now possible thanks to fixes in ddtrace 2.14.2.

See edx/edx-arch-experiments#692
@timmc-edx timmc-edx merged commit f28648e into master Oct 3, 2024
4 checks passed
@timmc-edx timmc-edx deleted the timmc/no-nr-wrap branch October 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants