feat: Add Subtitle Support for Native Player in Fullscreen Mode #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
Fixes: LEARNER-10259
HamzaIsrar12
requested review from
k1rill,
dixidroid,
omerhabib26 and
farhan-arshad-dev
dixidroid
approved these changes
Nov 6, 2024
farhan-arshad-dev
requested changes
Nov 18, 2024
Comment on lines
71
to
+76
| if (viewModel.isPlaying == null) { | ||
| viewModel.isPlaying = requireArguments().getBoolean(ARG_IS_PLAYING) | ||
| } | ||
| viewModel.transcripts = stringToObject<Map<String, String>>( | ||
| requireArguments().getString(ARG_TRANSCRIPTS, "") | ||
| ) ?: emptyMap() |
There was a problem hiding this comment.
As parameters are parsing from the bundle, better to move in the constructor. (Optional improvement)
Comment on lines
+29
to
+33
| val transcriptUrls: String, | ||
| @ColumnInfo("transcriptPaths") | ||
| val transcriptPaths: String, | ||
| @ColumnInfo("transcriptDownloadedStatus") | ||
| val transcriptDownloadedStatus: String, |
There was a problem hiding this comment.
transcriptPaths stores the downloaded transcript's local storage path right?
IMO, we can store Empty_String | null in the transcriptPaths to check whether the transcripts have been downloaded.
Comment on lines
+29
to
+31
| val transcriptUrls: String, | ||
| @ColumnInfo("transcriptPaths") | ||
| val transcriptPaths: String, |
There was a problem hiding this comment.
We need to perform the stress testing on these Columns.
| downloadDao.updateDownloadModel( | ||
| DownloadModelEntity.createFrom( | ||
| downloadTask.copy( | ||
| transcriptDownloadedStatus = TranscriptsDownloadedState.DOWNLOADED |
There was a problem hiding this comment.
Usecase to mark the Transcripts downloaded when transcriptUrls list is empty.
| @@ -32,7 +32,7 @@ ext { | |||
| fragment_version = "1.6.2" | |||
| constraintlayout_version = "2.1.4" | |||
| viewpager2_version = "1.0.0" | |||
| media3_version = "1.1.1" | |||
| media3_version = "1.4.1" | |||
There was a problem hiding this comment.
use-case to update the library version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Technical Changes: