Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove template literal in Cohesion snippet #27

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 6, 2024

In production, the events are not firing to Tagular due to window.tagular being undefined.
Temporary log to check for the cohesion configurations access in index.html plus adding the config if present to the global window object for testing.

@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-snippet branch from 0d212f8 to c07502f Compare November 6, 2024 20:29
Copy link
Member

@grmartin grmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand enough here to help, but heres a stamp and im here to assist after.

@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-snippet branch from 89b7be8 to f60d7de Compare November 6, 2024 23:15
@julianajlk julianajlk requested a review from a team as a code owner November 6, 2024 23:15
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-snippet branch 3 times, most recently from d97ba1b to f06c5b5 Compare November 7, 2024 13:20
@julianajlk julianajlk force-pushed the julianajlk/RV/EDX-932/rv-eventing-snippet branch from f06c5b5 to 8f8b2a6 Compare November 7, 2024 13:28
@julianajlk julianajlk merged commit 461089f into master Nov 7, 2024
4 checks passed
@julianajlk julianajlk deleted the julianajlk/RV/EDX-932/rv-eventing-snippet branch November 7, 2024 13:34
@julianajlk julianajlk changed the title temp: Check cohesionConfig access from htmlWebpackPlugin fix: Remove template literal in Cohesion snippet Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants