feat: Add Cohesion stage keys and remove taggy #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some miscellaneous work for Red Ventures Cohesion event tracking work:
taggy
from the Cohesion snippet as it was causing a bad request error.ConversionTracked
event:This event on the ticket had
category: "Order"
but this is not actually an legitimate option from the schema. This is why I was consistently receiving a 400 bad request even though my payload had all the attributes.This is also an issue for checkout.edx.org -> appropriate team has been notified.
Note: the Cohesion config object is added via
webpack.prod.config.js
, which I found also runs in Stage. There is awebpack.dev-stage.config.js
file, however, this is for local development with Stage variables.I don’t have the context why there is no webpack for stage or a separate build for stage in MFEs at edX, I am hopping that adding these to edx-internal will suffice to have Stage/Prod keys.
edx-internal PR: https://github.com/edx/edx-internal/pull/11880