Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cohesion stage keys and remove taggy #31

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 8, 2024

Some miscellaneous work for Red Ventures Cohesion event tracking work:

  • Adding the Cohesion keys from edx-internal to distinguish between stage and prod.
  • Removing taggy from the Cohesion snippet as it was causing a bad request error.
  • Updating the PayPal click event.
  • Updating the ConversionTracked event:
    This event on the ticket had category: "Order" but this is not actually an legitimate option from the schema. This is why I was consistently receiving a 400 bad request even though my payload had all the attributes.
    This is also an issue for checkout.edx.org -> appropriate team has been notified.

Note: the Cohesion config object is added via webpack.prod.config.js, which I found also runs in Stage. There is a webpack.dev-stage.config.js file, however, this is for local development with Stage variables.
I don’t have the context why there is no webpack for stage or a separate build for stage in MFEs at edX, I am hopping that adding these to edx-internal will suffice to have Stage/Prod keys.

edx-internal PR: https://github.com/edx/edx-internal/pull/11880

@julianajlk julianajlk requested a review from a team as a code owner November 8, 2024 17:52
Copy link

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the var names are right and the stage keys are used here 👍

@julianajlk julianajlk merged commit 963501c into master Nov 8, 2024
4 checks passed
@julianajlk julianajlk deleted the julianajlk/EDX-1584/rv-eventing-stage-cohesion branch November 8, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants