Add soft_extended_due_date field to Group model
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes server-side validation to ensure `extended_due_date < soft_extended_due_date`
MattyMay
force-pushed
the
add-soft-extended-due-date
branch
from
3ddb644
to
0fcfa26
Compare
|
@MattyMay Yes, students should only see the soft_extended_due_date when requesting their group object. We should chat about how to handle the backwards-incompatibility of the change for API users |
Migration: 1. Add soft_extended_due_date column 2. Add hard_extended_due_date column 3. Copy extended_due_date column to both new columns 4. Delete extended_due_date column deprecated extended_due_date behavior: - reads from soft_extended_due_date field - writes through to soft_extended_due_date and hard_extended_due_date
MattyMay
force-pushed
the
add-soft-extended-due-date
branch
from
fc419c6
to
0cc31c2
Compare
MattyMay
force-pushed
the
add-soft-extended-due-date
branch
from
2479607
to
2bc9eca
Compare
MattyMay
force-pushed
the
add-soft-extended-due-date
branch
from
2bc9eca
to
05abe1d
Compare
- add docstring to extended_deadline - add exception message check to test_error_soft_extended_due_date_after_extended_due_date - rename test for consistency
MattyMay
force-pushed
the
add-soft-extended-due-date
branch
from
4a85444
to
d551ed6
Compare
james-perretta
approved these changes
Sep 3, 2024
james-perretta
added a commit
that referenced
this pull request
Sep 19, 2024
…-changes Revert to before #687 was merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes server-side validation to ensure
extended_due_date < soft_extended_due_date@james-perretta should the student view of a group be changed to only show the
soft_extended_due_datelike howsoft_deadlineandhard_deadlinework?