Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-existing magic and gate level verilog because they may be … #102

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

d-m-bailey
Copy link
Contributor

@d-m-bailey d-m-bailey commented Jun 27, 2022

…out-of-date.

Without this change, existing gpio_defaults_block_* files will not be updated if changes are made to this script.

@RTimothyEdwards RTimothyEdwards added the flow Makefile or in-repository flow script changed label Oct 3, 2022
Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-bailey : Do you really want to remove the base files like gpio_defaults_block.mag or just the generated ones, which would be gpio_defaults_block_* rather than gpio_defaults_block*?

@d-m-bailey
Copy link
Contributor Author

@RTimothyEdwards good catch.

But we don't need or want any un-programmed default blocks in the user area, do we?

@RTimothyEdwards
Copy link
Contributor

@d-m-bailey : Is it located in the user project contents, or in the user project's copy of caravel? If the former, then it would be appropriate to remove it---it should not be there. If the latter, it's a source file. I know this doesn't go back into the user's repository, and I'm probably being way too pedantic about a use case that might not even exist, which is taking the contents of the tapeout directory and running a new local build with it.

Only remove created copies. Do not remove originals (which shouldn't exist in the user area).
@d-m-bailey
Copy link
Contributor Author

@RTimothyEdwards I was actually just thinking the same thing. If someone were to run the script in the caravel directory, it would wipeout the master copy.

I made the change. Can you review?

Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@d-m-bailey
Copy link
Contributor Author

Fixes #522.
Fixes #529.

@jeffdi
Copy link
Collaborator

jeffdi commented Mar 14, 2024

@a-omla @DavidRLindley -- this PR will require an update and verification of the tapeout flow on the platform. I can merge now or we can hold until you are ready to implement on the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flow Makefile or in-repository flow script changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants