Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sebastian Meyer <[email protected]>
  • Loading branch information
chrizzor and sebastian-meyer authored Jul 15, 2024
1 parent 8542dc0 commit df777d7
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions Classes/Controller/PageViewController.php
Original file line number Diff line number Diff line change
Expand Up @@ -376,11 +376,13 @@ protected function getScore(int $page, $specificDoc = null)
$uri = $this->uriBuilder->reset()
->setTargetPageUid($GLOBALS['TSFE']->id)
->setCreateAbsoluteUri(!empty($this->settings['forceAbsoluteUrl']) ? true : false)
->setArguments([
'eID' => 'tx_dlf_pageview_proxy',
'url' => $score['url'],
'uHash' => GeneralUtility::hmac($score['url'], 'PageViewProxy')
])
->setArguments(
[
'eID' => 'tx_dlf_pageview_proxy',
'url' => $score['url'],
'uHash' => GeneralUtility::hmac($score['url'], 'PageViewProxy')
]
)
->build();

$score['url'] = $uri;
Expand Down Expand Up @@ -487,8 +489,8 @@ protected function addViewerJS(): void
// Viewer configuration.
$viewerConfiguration = '$(document).ready(function() {
if (dlfUtils.exists(dlfViewer)) {
'.$jsViewer.'
viewerCount = '.($i-1).';
' . $jsViewer . '
viewerCount = ' . ($i - 1) . ';
}
});';
} else {
Expand Down

0 comments on commit df777d7

Please sign in to comment.