mandatory-UseEvent does not warn on effect stores

effector · Jun 10, 2022 · 5f94ae2 · 5f94ae2
1 parent 33f8718
commit 5f94ae2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/rules/mandatory-useEvent/examples/correct-effect-store-via-useStore.tsx b/rules/mandatory-useEvent/examples/correct-effect-store-via-useStore.tsx
@@ -0,0 +1,16 @@
+import React from "react";
+import { useEvent, useStore } from "effector-react";
+
+import { fetchFx } from "./model";
+
+const Button: React.FC = () => {
+  const loading = useStore(fetchFx.pending);
+
+  if (loading) {
+    return null;
+  }
+
+  return <button>click</button>;
+};
+
+export { Button };
diff --git a/rules/mandatory-useEvent/mandatory-useEvent.js b/rules/mandatory-useEvent/mandatory-useEvent.js
@@ -45,7 +45,7 @@ module.exports = {
           return;
         }
 
-        if (isInsideUseEventCall({ node, context })) {
+        if (isInsideEffectorHook({ node, context })) {
           return;
         }
 
@@ -61,14 +61,14 @@ module.exports = {
   },
 };
 
-function isInsideUseEventCall({ node, context }) {
+function isInsideEffectorHook({ node, context }) {
   const calleeParentNode = traverseParentByType(node.parent, "CallExpression");
 
   if (!calleeParentNode?.callee) return false;
 
   return nodeTypeIs.effectorReactHook({
     node: calleeParentNode.callee,
     context,
-    hook: ["useEvent", "useUnit"],
+    hook: ["useEvent", "useUnit", "useStore"],
   });
 }