Fix no-duplicate-on error messages during development in IDEA

effector · Feb 1, 2022 · e77e712 · e77e712
1 parent 0ce703d
commit e77e712
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/rules/no-duplicate-on/examples/correct-with-empty-on.ts b/rules/no-duplicate-on/examples/correct-with-empty-on.ts
@@ -0,0 +1,6 @@
+import { createEvent, createStore } from "effector";
+
+const $store = createStore(1);
+
+// Yeah, it's incorrect TS code, but it isn't this plugin's business
+$store.on();
diff --git a/rules/no-duplicate-on/no-duplicate-on.js b/rules/no-duplicate-on/no-duplicate-on.js
@@ -101,6 +101,10 @@ module.exports = {
 };
 
 function normalizePossibleArrayNode(node) {
+  if (!node) {
+    return [];
+  }
+
   if (node.type === "ArrayExpression") {
     return node.elements;
   }

diff --git a/rules/no-duplicate-on/no-duplicate-on.ts.test.js b/rules/no-duplicate-on/no-duplicate-on.ts.test.js
@@ -25,6 +25,7 @@ ruleTester.run("effector/no-duplicate-on.ts.test", rule, {
     "correct.ts",
     "correct-with-scopes.ts",
     "correct-with-nesting.ts",
+    "correct-with-empty-on.ts",
   ].map(readExampleForTheRule),
   invalid: ["incorrect-with-invalid-naming.ts"]
     .map(readExampleForTheRule)