fixed #3

egg- · Nov 20, 2015 · 3cb96b6 · 3cb96b6
1 parent 7209863
commit 3cb96b6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -18,13 +18,17 @@ ogp.type('website')
 ogp.description('description')
 ogp.site_name('site_name')
 ogp.url('http://ogp-meta.npm')
-// ogp.image('http://image url')
+ogp.image('http://image url')
+// reset
+ogp.image(null)
 ogp.image({
   url: 'http://image url',
   width: 400,
   height: 400
 })
-// ogp.video('http://video url')
+ogp.video('http://video url')
+// reset
+ogp.video(null)
 ogp.video({
   url: 'http://video url',
   width: 1024,

diff --git a/lib/ogp-meta.js b/lib/ogp-meta.js
@@ -50,6 +50,11 @@ OpenGraph.prototype.setObject = function (type, obj) {
  * @param {string} image.height
  */
 OpenGraph.prototype.image = function (image) {
+  // reset
+  if (!image) {
+    return delete this.meta['og:image']
+  }
+
   // for kakaotalk
   if (image.url) {
     this.setObject('image', image.url)
@@ -67,6 +72,10 @@ OpenGraph.prototype.image = function (image) {
 * @param {string} video.height
  */
 OpenGraph.prototype.video = function (video) {
+  // reset
+  if (!video) {
+    return delete this.meta['og:video']
+  }
   this.setObject('video', video)
 }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ogp-meta",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "author": {
     "name": "egg",
     "email": "[email protected]"

diff --git a/test/index.js b/test/index.js
@@ -7,13 +7,17 @@ ogp.type('website')
 ogp.description('description')
 ogp.site_name('site_name')
 ogp.url('http://ogp-meta.npm')
-// ogp.image('http://image url')
+ogp.image('http://image url')
+// reset
+ogp.image(null)
 ogp.image({
   url: 'http://image url',
   width: 400,
   height: 400
 })
-// ogp.video('http://video url')
+ogp.video('http://video url')
+// reset
+ogp.video(null)
 ogp.video({
   url: 'http://video url',
   width: 1024,