Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib,test,ci):drop support of Node <=6.x and use async function #37

Closed
wants to merge 13 commits into from

Conversation

qingdengyue
Copy link

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

1.Drop support of Node <=6.x
2.Change generator to async function
3.CI remove Node 6 support

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           6        6           
  Lines         210      210           
=======================================
  Hits          207      207           
  Misses          3        3
Impacted Files Coverage Δ
lib/helper.js 100% <100%> (ø) ⬆️
lib/cmd/start.js 99.18% <100%> (ø) ⬆️
lib/cmd/stop.js 93.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae9cb0...149c965. Read the comment docs.

@atian25
Copy link
Member

atian25 commented May 7, 2019

thanks for your work, but I don't think it's the right time to release a major version.

it's better to wait for eggjs/egg#3644 (Better Single Process / CLI Plugin System) and see what's need then release one major version together.

so could we just keep this PR for a while? thanks for your works again.

@qingdengyue
Copy link
Author

qingdengyue commented May 7, 2019

@atian25 ok.thanks.

@fengmk2
Copy link
Member

fengmk2 commented Feb 19, 2024

#58

@fengmk2 fengmk2 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants