dev sync 78883e6

eh2k · Dec 17, 2024 · fabaf2d · fabaf2d
1 parent ca4b980
commit fabaf2d
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -9,6 +9,12 @@
   <summary><b>ChangeLog</b></summary>
 
 ````
+== 2024-12-17
+   * Bugfix/Enchancement #117
+     * Parameter value was not visualized when modulations set (Bug since 2024-12-16)
+     * Midi pitch was added before quantizer
+     * V_OCT parameter value was added before quantized
+     * All modulations exept RND and TM are now added after quantizer
 == 2024-12-16
    * New paramters io-page
      * Quantizer-Root 

diff --git a/app/M-OSC/Waveforms.bin b/app/M-OSC/Waveforms.bin
diff --git a/app/M-OSC/Waveforms.cpp b/app/M-OSC/Waveforms.cpp
@@ -56,7 +56,9 @@ bool Quantizer::enabled() {
 
 int32_t Quantizer::Process(int32_t pitch, int32_t root, int8_t *note)
 {
-    auto ret = engine::qz_process(pitch, root + (PITCH_PER_OCTAVE * 8), note);
+    pitch -= root + (PITCH_PER_OCTAVE * 8);
+    auto ret = engine::qz_process(pitch, note);
+    ret += root + (PITCH_PER_OCTAVE * 8);
     return ret;
 }
 

diff --git a/app/SEQ/EuclidArp.bin b/app/SEQ/EuclidArp.bin
diff --git a/app/SEQ/EuclidArp.cpp b/app/SEQ/EuclidArp.cpp
@@ -417,7 +417,7 @@ void engine::process()
         _cv_out = _cv;
     }
 
-    _cv_out = (float)engine::qz_process(engine::cv_i32() + _cv_out * PITCH_PER_OCTAVE, 0, nullptr) / PITCH_PER_OCTAVE;
+    _cv_out = (float)engine::qz_process(engine::cv_i32() + _cv_out * PITCH_PER_OCTAVE, nullptr) / PITCH_PER_OCTAVE;
 
     if (engine::t() % 20 == 0)
     {

diff --git a/app/squares-and-circles-api.h b/app/squares-and-circles-api.h
@@ -322,7 +322,7 @@ namespace engine
 
     EXTERN_C bool qz_enabled();
     EXTERN_C const char* qz_name();
-    EXTERN_C int32_t qz_process(int32_t pitch, int32_t root, int8_t *note);
+    EXTERN_C int32_t qz_process(int32_t pitch, int8_t *note);
     EXTERN_C int16_t qz_lookup(int8_t note); //0-127 note-values
 }
 

diff --git a/platformio.ini b/platformio.ini
@@ -9,5 +9,5 @@
 
 [env:squares-and-circles]
 apps_json = ./app/index.json
-squares_and_circles_loader = 7ca7db0 ; minimum loader version
+squares_and_circles_loader = 78883e6 ; minimum loader version
 platform = .pio/