Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use unique_ptr for geometry in DD4hep_service, hand out not_null const pointers #1045

Merged
merged 9 commits into from
Oct 5, 2023
Merged

fix: use unique_ptr for geometry in DD4hep_service, hand out not_null const pointers #1045

merged 9 commits into from
Oct 5, 2023

Commits on Oct 4, 2023

  1. fix: license in DD4hep_service to LGPL per described provenance

    @wdconinc
    wdconinc committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    74feac4 View commit details
    Browse the repository at this point in the history

  2. fix: store detector geometry in const unique_ptr

    @wdconinc
    wdconinc committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    1090c25 View commit details
    Browse the repository at this point in the history

  3. fix: also make CellIDPositionConverter a unique_ptr

    @wdconinc
    wdconinc committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    606d0b7 View commit details
    Browse the repository at this point in the history

  4. fix: hand out not_null const pointers to detector and converter

    @wdconinc
    wdconinc committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e5841fb View commit details
    Browse the repository at this point in the history

  5. fix: find_package Microsoft.GSL

    @wdconinc
    wdconinc committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    83d2993 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Merge branch 'main' into shared-ptr-const-detector

    @c-dilks
    c-dilks authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e8415e9 View commit details
    Browse the repository at this point in the history

  2. fix: don't use gsl::not_null in calls, keep it where on class members

    @wdconinc
    wdconinc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b9b97f4 View commit details
    Browse the repository at this point in the history

  3. fix: no gsl/gsl include needed anymore in algorithms

    @wdconinc
    wdconinc committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    80b83e0 View commit details
    Browse the repository at this point in the history

  4. fix: no parentheses in return of unique_ptr::get() 

    Co-authored-by: Dmitry Kalinkin <[email protected]>
    @wdconinc @veprbl
    wdconinc and veprbl authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2a3c84a View commit details
    Browse the repository at this point in the history