Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Multiple Primary MC-Cluster Associations for Topoclusters #1631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ruse-traveler
Copy link
Contributor

Briefly, what does this PR introduce?

This PR applies the #1396 treatment to the ImagingClusterReco algorithm. As a reminder:

  • Previously, the truth in the truth-cluster associations was defined to be the MCParticle of the 1st contribution stored in the list of contributions to the SimCalorimeterHit corresponding to the highest energy hit in the cluster.
  • The logic here is
    1. Multiple MC-Cluster associations are created,
    2. Associations link back to primary (generator status == 1) MC particles, and
    3. Each association carries a weight of E_{contributed} / E_{cluster}.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

It doesn't introduce breaking changes, but it does substantially alter cluster-MC associations in such a way that users may have account for in downstream analysis code.

Does this PR change default behavior?

Yes: MC-Cluster associations (edm4eic::MCRecoClusterParticleAssociations) will now contain multiple associations per clusters, and will link back to primary (status == 1) MC particles.

@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label Oct 13, 2024
@ruse-traveler ruse-traveler marked this pull request as ready for review October 13, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant