Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lookup parameter default values configurable through config file #161

Open
e-backmark-ericsson opened this issue Mar 12, 2020 · 0 comments

Comments

@e-backmark-ericsson
Copy link
Member

Description

It is most certainly not the case that all users of REMReM would like to have the same default values on the REMReM lookup parameters as the ones currently hard coded in the code. I'd like to see the following parameters having configurable default values in config files(s):
failIfNoneFound
failIfMultipleFound
lookupInExternalERs
lookupLimit

Motivation

To make it possible to control the default behavior of the lookup function towards Event Repository per deployment of REMReM.

Exemplification

The users of some REMReM instances might have most of their lookups done towards the local Event Repository, and therefore lookupInExternalERs could be set to false, while users of other REMReM instances might have most of their lookups done towards external ERs and then they should not need to provide the lookupInExternalERs=True in all their calls to REMReM.

Benefits

Less parameters to be provided by REMReM users in each call made to REMReM

Possible Drawbacks

It is not possible to rely on the default values described in the REMReM documentation on these values, as they can be changed per deployment. That could be mitigated by clear descriptions updated by the teams deploying REMReM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant