Added lenientValidation support to REMReM generate #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raja-maragani
requested review from
durga-vasaadi,
SantoshNC68,
magnusbaeck,
e-backmark-ericsson,
Umadevi-Kapu and
a team
|
This PR depends on eiffel-community/eiffel-remrem-semantics#128 where I just posted some comments. I'll hold off the review until that PR progresses. |
SantoshNC68
reviewed
Jul 20, 2020
CLI works as backward compatibility. API default values from the user is a separate part issue |
SantoshNC68
approved these changes
Jul 21, 2020
added 2 commits
July 22, 2020 10:52
wiki/markdown/usage/generate-cli.md
Outdated
| @@ -20,6 +20,8 @@ usage: java -jar | |||
|
|
|||
| -mp,--messaging_protocol name of messaging protocol to be used, e.g. eiffelsemantics | |||
|
|
|||
| -lv,--lenientValidation lenientValidation will perform the only mandatory field validation and non-mandatory validation failures will place in Eiffel message as a new property(remremGenerateFailures) | |||
wiki/markdown/usage/generate-cli.md
Outdated
| @@ -20,6 +20,8 @@ usage: java -jar | |||
|
|
|||
| -mp,--messaging_protocol name of messaging protocol to be used, e.g. eiffelsemantics | |||
|
|
|||
| -lv,--lenientValidation lenientValidation will perform the only mandatory field validation and non-mandatory validation failures will place in Eiffel message as a new property(remremGenerateFailures) | |||
| ## Lenient Validation | ||
| The Lenient validation introduced in REMReM Generate since the version 2.1.0 | ||
|
|
||
| Using the lenient validation user continue the Eiffel generate with non-fatal fields in the message. |
There was a problem hiding this comment.
eiffel event generation
| [Eiffel REMReM semantics](https://github.com/eiffel-community/eiffel/tree/master/schemas) | ||
| for more about mandatory and optional fields. | ||
|
|
||
| The Lenient validation will perform the only mandatory field validation and non-mandatory validation failures will place in Eiffel message as a new property(remremGenerateFailures) |
| ] | ||
| ``` | ||
|
|
||
| The lenient validation created new message property with "remremGenerateFailures" |
There was a problem hiding this comment.
new element in customData
|
If no other comments, I will merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
#171
Description of the Change
Added Lenient Validation support to REMReM Generate, The Lenient Validation will perform the only mandatory field validation and non-mandatory validation failures will place in Eiffel message as a new property(remremGenerateFailures)
Alternate Designs
Benefits
The REMReM generate validation will not fail on non-fetal Eiffel message field issues. This feature is an option to the user, the user can decide the enable/disable the Lenient Validation. By default it is disabled.
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: @raja-maragani