Update to work with the ETOS controller #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
force-pushed
the
etos-controller
branch
from
9bb3005 to
fcc00ef
Compare
andmat900
reviewed
Aug 20, 2024
fredjn
reviewed
Sep 25, 2024
We need to rewrite large parts of the environmen provider to get rid of lots of legacy bits. I won't do that now, since the change would be too large.
- Clarified TODOs
t-persson
force-pushed
the
etos-controller
branch
from
61a0828 to
6a8bf8b
Compare
|
Force push since I had to rebase |
andmat900
reviewed
Nov 20, 2024
fredjn
requested changes
Nov 21, 2024
fredjn
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
eiffel-community/etos#242
Description of the Change
Update the environment provider to work with the new ETOS kubernetes controller.
This change should still work with the current way of running ETOS and will only "activate" if the environment provider
detects that it is running as a part of a TestRun resource.
Alternate Designs
I thought about implementing a separate package that could run independently from the current way, however I decided against this as it would require me to move way from the current implementation of the environment provider which is an implementation that works. I do not want this change to be a complete rewrite; we must piggy-back on the code that we are currently running.
I also thought about creating a docker container and running the provider as a part of the EnvironmentRequest resource, but that would also move away too far from the current implementation in ETOS. This is something that we should do in steps so that we do not break everything.
Possible Drawbacks
I did increase the complexity of the environment provider. I outlined some reasons for this in the alternate designs part. This complexity should be removed when the PoC is finished. Either remove the etos controller parts or the current environment provider part.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]