Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem where release_all is not run correctly #110

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

t-persson
Copy link
Collaborator

Applicable Issues

None

Description of the Change

release_full_environment never ran release_environment because it tried to iterate over sub_suites in a dictionary that does not have that key. The default value is then an empty list which we don't iterate over.
Fix the code so that the correct key is retrieved from ETCD.

Alternate Designs

None

Possible Drawbacks

None

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Tobias Persson [email protected]

@t-persson t-persson requested a review from a team as a code owner September 16, 2024 08:00
@t-persson t-persson requested review from fredjn and andmat900 and removed request for a team September 16, 2024 08:00
@t-persson t-persson merged commit 6983eae into eiffel-community:main Sep 17, 2024
1 check passed
@t-persson t-persson deleted the fix-release branch September 17, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants