test: go 1.21 compatibility #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.21 added an optimization that broke one of our tests. Comparing context is not well-defined in Go so we compare a value inside the context instead. This should work regardless of Go version I hope...
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 55.20% 55.09% -0.11%
==========================================
Files 62 62
Lines 3556 3561 +5
==========================================
- Hits 1963 1962 -1
- Misses 1484 1490 +6
Partials 109 109
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.21 added an optimization that broke one of our tests. Comparing context is not well-defined in Go so we compare a value inside the context instead.
This should work regardless of Go version I hope...