ci: remove deprecated goreview #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent breakage from the goreview repo being decommissioned. All linting now done by GolangCI-Lint.
odsod
force-pushed
the
remove-goreview
branch
from
c20d75d
to
fa9fc7f
Compare
maxekman
approved these changes
Oct 31, 2024
|
I'll check the CI fail, it also happened in master last build. |
|
@maxekman looks related to Go version bump |
|
We should probably set a Go version in the CI, that is the root cause. |
|
@maxekman I tried pushing a quick one with the previous Go version - can pin further back if it doesn't work |
|
Oh, thanks! We were thinking perhaps 1.19, but let's see how this goes first. |
|
Thanks @odsod, let's go with this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent breakage from the goreview repo being decommissioned.
All linting now done by GolangCI-Lint.