Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for multiple multiplexing switches #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jstroem
Copy link

@jstroem jstroem commented Sep 16, 2021

Does also add support for SG_MUL_VAL_ defs

Copy link

@hashemmm96 hashemmm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution! Sorry for the late review 🙇

I think this looks nice. However we've had some changes in the CI for this project so we do some additional checks on PRs. Let's start by rebasing this PR on latest master, then check if there are additional changes needed.

Copy link

@hashemmm96 hashemmm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, by adding this feature, the dbc file linter will complain about multiple multiplexing switches even though they are supported. This can be remediated by modifying the linter in pkg/dbc/analysis/passes/multiplexedsignals/analyzer.go

@tomrijntjes
Copy link

tomrijntjes commented Apr 17, 2023

I would appreciate this feature very much. Is there anything I can do?

edit: merging main works fine without conflicts. I'm not sure how to reproduce the linter issue mentioned above.

@bryanjhv
Copy link

bryanjhv commented Jul 7, 2023

@tomrijntjes something like this.

go run go.einride.tech/can/cmd/cantool lint <file-or-dir>

@RangelReale
Copy link

In the python cantools tests, there is a dbc file with a list of multiplex ranges in the SG_MUL_VAL_ message.
Is there a documentation of this format?

@odsod odsod requested review from a team and removed request for odsod and alethenorio February 28, 2024 07:36
@Jassob Jassob added stale Stale and removed stale Stale labels May 16, 2024
@Jassob
Copy link
Member

Jassob commented May 16, 2024

Hello @RangelReale, we've used http://www.mcu.so/Microcontroller/Automotive/dbc-file-format-documentation_compress.pdf as reference.

You can cross-reference it for information about SG_MUL_VAL_.

@Jassob
Copy link
Member

Jassob commented May 16, 2024

@jstroem Please confirm if you're still interested in getting this PR merged, otherwise we'll close it in 14 days unless someone adopts it until then.

Copy link
Member

@Jassob Jassob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on current master

@Jassob Jassob added dbc Changes to the DBC parser stale Stale labels May 16, 2024
@Edholm Edholm requested review from maxekman and removed request for a team September 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbc Changes to the DBC parser stale Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants