-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for multiple multiplexing switches #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contribution! Sorry for the late review 🙇
I think this looks nice. However we've had some changes in the CI for this project so we do some additional checks on PRs. Let's start by rebasing this PR on latest master, then check if there are additional changes needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, by adding this feature, the dbc file linter will complain about multiple multiplexing switches even though they are supported. This can be remediated by modifying the linter in pkg/dbc/analysis/passes/multiplexedsignals/analyzer.go
I would appreciate this feature very much. Is there anything I can do? edit: merging main works fine without conflicts. I'm not sure how to reproduce the linter issue mentioned above. |
@tomrijntjes something like this. go run go.einride.tech/can/cmd/cantool lint <file-or-dir> |
In the python cantools tests, there is a dbc file with a list of multiplex ranges in the |
Hello @RangelReale, we've used http://www.mcu.so/Microcontroller/Automotive/dbc-file-format-documentation_compress.pdf as reference. You can cross-reference it for information about |
@jstroem Please confirm if you're still interested in getting this PR merged, otherwise we'll close it in 14 days unless someone adopts it until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on current master
Does also add support for SG_MUL_VAL_ defs