add no_std support #1
Conversation
ghost
mentioned this pull request
|
Ping |
| std = [] | ||
|
|
||
| [target.'cfg(not(feature = "std"))'.dependencies] | ||
| libm = "0.1.2" |
There was a problem hiding this comment.
Is this only for fract? Their implementation of trunc (which fract is a simple transformation of) seems kinda suspect. Specifically it forces a volatile read which can result in poor performance since now AIUI it must be spilled to the stack instead of kept solely in registers. Look at their implementation of force_eval to see the volatile read. Might be worth putting in a PR to them. It looks OK from a behaviour perspective though so we can deal with that later if we want to.
There was a problem hiding this comment.
Yes, this is only for fract.
The force_eval is copied from musl: https://git.musl-libc.org/cgit/musl/tree/src/math/trunc.c
I honestly haven't looked at performance. I want this mostly for wasmi.
That being said, libm is a non-public dependency, so it can be switched out any time.
There was a problem hiding this comment.
Fair enough! If it's good enough for musl, it's good enough for me
|
Could you release this, please? |
Part of wasmi-labs/wasmi#122