Increase dependency review severity requirement and work around dataf…

…low test failures (#852) Co-authored-by: Werner Dietl <[email protected]>
eisop · Aug 18, 2024 · 4b710d4 · 4b710d4
1 parent ef99975
commit 4b710d4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -14,5 +14,6 @@ jobs:
       - name: 'Dependency review'
         uses: actions/dependency-review-action@v4
         with:
+          fail-on-severity: high
           retry-on-snapshot-warnings: true
           retry-on-snapshot-warnings-timeout: 600
diff --git a/checker/bin-devel/test-cftests-junit-jdk21.sh b/checker/bin-devel/test-cftests-junit-jdk21.sh
@@ -11,5 +11,6 @@ SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 export ORG_GRADLE_PROJECT_useJdkCompiler=21
 source "$SCRIPTDIR"/clone-related.sh
 
-
-./gradlew test -x javadoc -x allJavadoc --console=plain --warning-mode=all
+# Adding --max-workers=1 to avoid random failures in Github Actions. An alternative solution is to use --no-build-cache.
+# https://github.com/eisop/checker-framework/issues/849
+./gradlew test -x javadoc -x allJavadoc --console=plain --warning-mode=all --max-workers=1
diff --git a/checker/bin-devel/test-cftests-junit.sh b/checker/bin-devel/test-cftests-junit.sh
@@ -10,5 +10,6 @@ SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 # shellcheck disable=SC1090# In newer shellcheck than 0.6.0, pass: "-P SCRIPTDIR" (literally)
 source "$SCRIPTDIR"/clone-related.sh
 
-
-./gradlew test -x javadoc -x allJavadoc --console=plain --warning-mode=all
+# Adding --max-workers=1 to avoid random failures in Github Actions. An alternative solution is to use --no-build-cache.
+# https://github.com/eisop/checker-framework/issues/849
+./gradlew test -x javadoc -x allJavadoc --console=plain --warning-mode=all --max-workers=1
diff --git a/checker/bin-devel/test-cftests-nonjunit.sh b/checker/bin-devel/test-cftests-nonjunit.sh
@@ -10,8 +10,9 @@ SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 # shellcheck disable=SC1090# In newer shellcheck than 0.6.0, pass: "-P SCRIPTDIR" (literally)
 source "$SCRIPTDIR"/clone-related.sh
 
-
-./gradlew nonJunitTests -x javadoc -x allJavadoc --console=plain --warning-mode=all
+# Adding --max-workers=1 to avoid random failures in Github Actions. An alternative solution is to use --no-build-cache.
+# https://github.com/eisop/checker-framework/issues/849
+./gradlew nonJunitTests -x javadoc -x allJavadoc --console=plain --warning-mode=all --max-workers=1
 ./gradlew publishToMavenLocal -x javadoc -x allJavadoc --console=plain --warning-mode=all
 # Moved example-tests out of all tests because it fails in
 # the release script because the newest maven artifacts are not published yet.