-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website updates #5
Changes from 2 commits
ee57a34
7410e95
ea5a951
6906143
722ec3e
9efd1c4
573996f
afaae9f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,14 @@ jobs: | |
- name: Build with Maven | ||
run: mvn -B package --file pom.xml | ||
|
||
# Copy the files to the gh-pages branch | ||
- name: Copy To Branches Action | ||
uses: planetoftheweb/[email protected] | ||
env: | ||
key: main | ||
branches: gh-pages | ||
files: afu-template.md cf-template.md CFLogo.png README.md index.md pom.xml 404.html src/main/java/io/github/eisop/website/EisopSiteGenerator.java | ||
|
||
# Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive | ||
# - name: Update dependency graph | ||
# uses: advanced-security/maven-dependency-submission-action@v3 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,6 +161,9 @@ public static void main(String[] args) throws IOException { | |
e.printStackTrace(); | ||
} | ||
|
||
File releaseOrg = new File(String.valueOf(javadocFolder) + "/checker-javadoc/org"); | ||
FileUtils.copyDirectoryToDirectory(releaseOrg, javadocFolder); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it enough to move the directory over? Or why do we need two copies of the javadoc? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we could just move the directory I believe |
||
|
||
// Move index.html | ||
// File releaseHTML = new File(String.valueOf(releaseFolder) + | ||
// "/docs/tutorial/index.html"); | ||
|
@@ -305,6 +308,11 @@ public static void main(String[] args) throws IOException { | |
|
||
System.out.println("Latest release: " + String.valueOf(latestRelease)); | ||
|
||
// Copy CFLogo.png to cf/ | ||
File cfLogo = new File(String.valueOf(latestRelease) + "/tutorial/CFLogo.png"); | ||
wmdietl marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does this PR need to add file There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I had initially wanted to upload the .png file, but decided it was better to take it from the latest release in case you want to change the logo at some point. |
||
File newCFLogo = new File(System.getProperty("user.dir") + "/cf/CFLogo.png"); | ||
FileUtils.copyFile(cfLogo, newCFLogo); | ||
|
||
getAFU(); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really be executed for a PR? It would seem odd that each PR run updates what is displayed on the live website.
Also, as
EisopSiteGenerator
isn't executed, the templates and releases aren't updated.So maybe this should go somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. The alternative is having to copy over the changes from the main branch to the gh-pages branch manually. This just saves a step before running
EisopSiteGenerator
on the gh-pages branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! From the log it looks like this isn't working correctly. I've filed #11 for follow-up work.