Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect MergeQueue bool flag when querying github PRs #369

Closed
wants to merge 1 commit into from

Conversation

pleicht
Copy link

@pleicht pleicht commented Nov 29, 2023

Disclaimer: I have never written Go code before.

For enterprise clients on a github version < 3.11 MergeQueue support isn't implemented. As a result

mergeQueueEntry {
    id
}

isn't valid inside of the pull request query.

This is logically the correct way to do this, but I understand two of these files are generated and I shouldn't edit them, however I'm unsure of how to actually generate client.go and operations.go.

If someone can point me in the right direction I can update the PR to generate client.go and operations.go correctly

Closes #356

@ejoffe
Copy link
Owner

ejoffe commented Dec 7, 2023

@pleicht : Thank you for your pr, I think I found a way to acheive this without the hacks inside the generated code.
Please checkout PR #370. If you can test it and validate that it works, I'll release the fix.

@ejoffe ejoffe closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version incompatible with older GitHub Enterprise Server usages.
2 participants