Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds option to show pr titles in stack description #371

Conversation

georgiemathews
Copy link
Contributor

@georgiemathews georgiemathews commented Dec 8, 2023

Summary

This PR adds a new repository config field that toggles displaying each PR's title in the PR body's stack description like so:

**Stack**:
- Title B #2 ⬅
- Title A #1

This is helpful for github enterprise instances that are not on the latest version where PR titles automatically populate alongside PR numbers.

The field is named showPrTitlesInStack and defaults to false.

I've added respective tests to maintain coverage with the added functionality in github/githubclient/client.go and have built and installed this binary locally to dogfood the new behavior.

@georgiemathews
Copy link
Contributor Author

@ejoffe Let me know what you think!

Copy link
Owner

@ejoffe ejoffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for contributing!

@ejoffe ejoffe merged commit 66dd2f0 into ejoffe:master Dec 11, 2023
1 check passed
@ejoffe
Copy link
Owner

ejoffe commented Dec 11, 2023

Released in v0.14.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants