Set LastHealthyAt every time a replica appears RW in an engine

SQUASH THIS

Signed-off-by: Eric Weber <[email protected]>

controller/volume_controller.go

@@ -718,16 +718,15 @@ func (c *VolumeController) ReconcileEngineReplicaState(v *longhorn.Volume, es ma
 			}
 			r.Spec.DesireState = longhorn.InstanceStateStopped
 		} else if mode == longhorn.ReplicaModeRW {
-			// record once replica became healthy, so if it
-			// failed in the future, we can tell it apart
-			// from replica failed during rebuilding
+			now := c.nowHandler()
 			if r.Spec.HealthyAt == "" {
 				c.backoff.DeleteEntry(r.Name)
-				now := c.nowHandler()
+				// Set HealthyAt to distinguish this replica from one that has never been rebuilt.
 				r.Spec.HealthyAt = now
-				r.Spec.LastHealthyAt = now
 				r.Spec.RebuildRetryCount = 0
 			}
+			// Set LastHealthyAt to record the last time this replica became RW in an engine.
+			r.Spec.LastHealthyAt = now
 			healthyCount++
 		}
 	}