Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm64 detection logic #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ssbarnea
Copy link

Fixes: #369

@ssbarnea
Copy link
Author

@eliask May you please press the magic approve button so we can see the results?

PS. BTW, I also noted some tox.ini config mistakes which prevents its use by some users. To be more clear, presence of tox-ev plugin breaks it as you rely solely on pip commands instead of allowing tox to manage dependencies itself.

@ssbarnea ssbarnea marked this pull request as ready for review October 24, 2024 13:25
@ssbarnea
Copy link
Author

@ekalinin Maybe you could disable to approval to allow us to test our PR? There is nothing in the GHA workflow file to cause concerns and github runners are free for open-source anyway. Tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with os.uname() machine identifier text case
1 participant