Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms-key): filter pending replica deletion state #409

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bdellegrazie
Copy link
Contributor

@bdellegrazie bdellegrazie commented Nov 6, 2024

Filter custom KMS keys in PendingReplicaDeletion as they've already been scheduled for deletion.

Closes #408

@bdellegrazie bdellegrazie force-pushed the fix/mutliregion-key-filter branch from e34fd8c to ffebfa4 Compare November 6, 2024 21:12
@ekristen
Copy link
Owner

ekristen commented Nov 6, 2024

@bdellegrazie thanks for the contribution, with test coverage and semantic commit messaging all in one go!

I have one request, can you modify it to use a scope that targets the resource kms-key so it's more apparent in the automated changelog and git log what it was.

This should do the trick!

git commit --amend -m "fix(kms-key): filter pending replica deletion state"
git push origin fix/multiregion-key-filter

As soon as this is done it'll get merged and a new version cut immediately.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Filter custom KMS keys in PendingReplicaDeletion as they've
already been scheduled for deletion.

Closes #408
@bdellegrazie bdellegrazie force-pushed the fix/mutliregion-key-filter branch from ffebfa4 to 86938c4 Compare November 6, 2024 22:29
@bdellegrazie
Copy link
Contributor Author

@ekristen done.

@ekristen ekristen enabled auto-merge November 6, 2024 22:30
@bdellegrazie bdellegrazie changed the title fix: filter custom KMS in pending-replica-deletion fix(kms-key): filter pending replica deletion state Nov 6, 2024
@ekristen ekristen merged commit 3e7bff6 into ekristen:main Nov 6, 2024
6 checks passed
@ekristen
Copy link
Owner

ekristen commented Nov 6, 2024

🎉 This PR is included in version 3.29.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdellegrazie bdellegrazie deleted the fix/mutliregion-key-filter branch November 6, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-region custom KMS Keys and deletion
3 participants