-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to wasm-pack build --target bundler
and Vite plugins for loading WebAssembly component
#75
Conversation
Sweet, thanks! I hope this fixes the Docker build issue too, let's see. Edit: It doesn't, I'll try to fix that in a separate PR! |
Getting this error in
|
Hi @ntninja, thank you for contributing. I think the build is failing though after adding the |
…ding WebAssembly component Fixes dev-mode. This makes use of native Vite capabilities to load the WebAssembly component and appears to be the recommended approach nowadays. See: rustwasm/wasm-pack#1106 (comment)
Apparently @swc/core 1.7.0 (recently released) has a regression that breaks vite-plugin-top-level-await: Menci/vite-plugin-top-level-await#52
66e38ba
to
1867423
Compare
Unfortunately there appears to be a regression between vite-plugin-top-level-await and recently released @swc/core 1.7.0: I’ve pinned @swc/core 1.6.* to work around this. Sorry for the noise! |
Hi @ntninja — it looks like it's still failing CI due to an issue with package installation in |
…cker environment vs NPM 9 locally
It seems that the package-lock.json generated by NPM 9 (local) and NPM 10 (Dockerfile) slightly differs in regards to the directory dependency, which made the |
Thank you! |
Fixes dev-mode. This makes use of native Vite capabilities to load the WebAssembly component and appears to be the recommended approach nowadays.
See: rustwasm/wasm-pack#1106 (comment)