some fixes

elalish · Oct 15, 2024 · ec9e54b · ec9e54b
1 parent 66fa688
commit ec9e54b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -160,6 +160,7 @@ else()
       -Wno-array-bounds
       -Wno-stringop-overflow
       -Wno-alloc-size-larger-than
+      -Wno-narrowing
     )
   else()
     list(APPEND WARNING_FLAGS -Wall -Wno-unused -Wno-shorten-64-to-32)

diff --git a/src/csg_tree.cpp b/src/csg_tree.cpp
@@ -111,7 +111,7 @@ std::shared_ptr<CsgNode> CsgNode::Boolean(
 }
 
 std::shared_ptr<CsgNode> CsgNode::Translate(const vec3 &t) const {
-  mat3x4 transform(1.0);
+  mat3x4 transform = Identity3x4();
   transform[3] += t;
   return Transform(transform);
 }

diff --git a/src/impl.h b/src/impl.h
@@ -28,7 +28,7 @@ namespace manifold {
 struct Manifold::Impl {
   struct Relation {
     int originalID = -1;
-    mat3x4 transform = mat3x4(1);
+    mat3x4 transform = Identity3x4();
     bool backSide = false;
   };
   struct MeshRelationD {