Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix compilation flag lost in CMake refactor #1005

Merged
merged 1 commit into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. Need to fix compilation flag lost in CMake refactor

    Looks like we lost the O3 flag always being on.  This was good for some
    fun trying to figure out why performance had dropped off so dramatically
    - turned out it was simply because prior builds had NEVER been without
    O3, so all builds - Debug or Release - were optimized.
    
    On the other hand, there are arguments for and against O3 with debug
    builds.  The optimizations complicate/obscure debugging, but it's also
    an order of magnitude slower running.  Rather than be completely either
    or, this PR defines a MANIFOLD_OPTIMIZED variable that a user can
    specify to ON explicitly.  Build types Release and RelWithDebInfo will
    always have O3, and for other cases it'll be up to whether the user has
    explicitly requested optimized building with MANIFOLD_OPTIMIZED.
    starseeker committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4e93c4e View commit details
    Browse the repository at this point in the history