remove face index on HalfEdge #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't appear to actually be used
|
Interesting, I thought this is removed in the last PR. I guess I forgot to commit the actual removal. |
|
Looks like some places I missed due to not using tbb yet |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
- Coverage 91.84% 87.97% -3.87%
==========================================
Files 37 62 +25
Lines 4976 8575 +3599
Branches 0 1047 +1047
==========================================
+ Hits 4570 7544 +2974
- Misses 406 1031 +625 ☔ View full report in Codecov by Sentry. |
pca006132
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't appear to actually be used
maybe there's something I'm missing...