DroppedSpanStats: do not flatten duration #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APM Server expects objects and flattening those as the agent did prior to this PR is not accepted by the server.
Reformat once again.
format once again
gregkalapos
commented
Sep 7, 2023
gregkalapos
changed the title
Mpdreamz
approved these changes
Sep 11, 2023
Mpdreamz
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APM Server expects objects and flattening those as the agent did prior to this PR is not accepted by the server.
Furthermore, in APM Server 8.9.x, there was an issue that in such cases (specifically when the
durationfield was empty (or sending it flattened)) caused a panic. This was fixed in 8.10, but the APM Server would still ignored the flatteneddurationobject ondropped_spans_stats.Therefore, this PR changes
DroppedSpanStats.csto use sub-objects for theDurationobject. We do this in all other cases as well.