-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: override git checks when only docs #2185
Conversation
Co-authored-by: Jan Calanog <[email protected]>
Co-authored-by: Jan Calanog <[email protected]>
aha, somehow the branch protection is not that fine granularity, but affect to all the let me put the fix |
There's a few targets that run on:
Which now might run erroneously? e.g |
That's a good point. In this particular case, it's not necessary since this is trying to solve the GitHub checks in the branch protection. We might need to revisit the current implementation so snapshoty or similar ones run only when needed, aka when everything run successfully. At the moment, the CI workflows, in this particular project, are a bit decentralised. I'll keep a note so we can review the implementation. |
Not sure why this is happening, also happens for me locally.. |
Opened #2186 to attempt to make See also: sagiegurari/cargo-make#67 |
This should avoid the situation that we have when a docs changes are blocked by