Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: override git checks when only docs #2185

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 19, 2023

This should avoid the situation that we have when a docs changes are blocked by

image

@v1v v1v requested review from a team September 19, 2023 12:14
@v1v v1v self-assigned this Sep 19, 2023
reakaleek
reakaleek previously approved these changes Sep 19, 2023
reakaleek
reakaleek previously approved these changes Sep 19, 2023
@reakaleek
Copy link
Member

reakaleek commented Sep 19, 2023

mhmm. Looking at the created status checks, there is also test-windows / tests

image

@v1v
Copy link
Member Author

v1v commented Sep 19, 2023

mhmm. Looking at the created status checks, there is also test-windows / tests

aha, somehow the branch protection is not that fine granularity, but affect to all the tests jobs

let me put the fix

@Mpdreamz
Copy link
Member

There's a few targets that run on:

on:
  workflow_run:
    workflows: ['test-linux']

Which now might run erroneously? e.g snapshotty.

@v1v
Copy link
Member Author

v1v commented Sep 19, 2023

Which now might run erroneously? e.g snapshotty.

That's a good point. In this particular case, it's not necessary since this is trying to solve the GitHub checks in the branch protection.

We might need to revisit the current implementation so snapshoty or similar ones run only when needed, aka when everything run successfully. At the moment, the CI workflows, in this particular project, are a bit decentralised. I'll keep a note so we can review the implementation.

@Mpdreamz
Copy link
Member

:: clean-profiler: Failed! Timeout 00:05:00 occured while running "cargo make clean" (5 m 1 s)

Not sure why this is happening, also happens for me locally..

@Mpdreamz
Copy link
Member

Opened #2186 to attempt to make cargo make happy.

See also: sagiegurari/cargo-make#67

@Mpdreamz Mpdreamz merged commit 5e1eccd into elastic:main Sep 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants