Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: use GH_TOKEN #2191

Merged
merged 1 commit into from
Sep 21, 2023
Merged

action: use GH_TOKEN #2191

merged 1 commit into from
Sep 21, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 21, 2023

This should fix the error when using gh

@v1v v1v requested a review from a team September 21, 2023 18:27
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GITHUB_TOKEN and GH_TOKEN should be equivalent according to: https://cli.github.com/manual/gh_help_environment

Added that env just after our latest release. Happy to settle/standardize on GH_TOKEN though!

Let me know if I missed anything.

@Mpdreamz Mpdreamz merged commit 7f0bd80 into elastic:main Sep 21, 2023
13 checks passed
@v1v
Copy link
Member Author

v1v commented Sep 21, 2023

GITHUB_TOKEN and GH_TOKEN

That was my understanding too...

I saw it failed recently in https://github.com/elastic/apm-agent-dotnet/actions/runs/6249887768/job/16967549984#step:10:17

gh: To use GitHub CLI in a GitHub Actions workflow, set the GH_TOKEN environment variable. Example:
  env:
    GH_TOKEN: ${{ github.token }}

That's the reason for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants