Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'cloud.project.id' for GCP metadata to be the 'project-id' #1511

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Change 'cloud.project.id' for GCP metadata to be the 'project-id' #1511

merged 1 commit into from
Sep 20, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Sep 15, 2023

Closes: #1509

@trentm trentm requested a review from a team as a code owner September 15, 2023 00:28
@trentm
Copy link
Member Author

trentm commented Sep 20, 2023

Thanks for the reviews. I don't have permissions to merge this, so I'd appreciate if one of you would.

@kruskall kruskall merged commit 5b156f2 into elastic:main Sep 20, 2023
9 checks passed
@trentm trentm deleted the trentm/gcp-metadata-cloud-project-id branch January 18, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@lahsivjar lahsivjar lahsivjar approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 826] changes to metadata.cloud.project.* fields collected for GCP
4 participants
@trentm @dmathieu @lahsivjar @kruskall